Lightning-AI / Lightning-AI/pytorch-lightning
add sub_dir to csv logger constructor
Open
Nobody has claimed this yet.
refactor
- Dominant language
- Python
- Stars
- 31.4k
- Forks
- 3.8k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 6
Description
### Outline & Motivation
The `TensorBoardLogger` has a `sub_dir`parameter in its constructor. The CSV logger doesn't
### Pitch
Add the `sub_dir`and functionality to CSV logger
### Additional context
_No response_
cc @lantiga @justusschock
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the TensorBoardLogger constructor with the CSV logger constructor and follow how the existing sub_dir parameter is handled. Update the CSV logger so it accepts and applies the same subdirectory behavior, then verify the logger tests cover construction and output in that subdirectory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100