Lightning-AI / Lightning-AI/pytorch-lightning
self.all_gather does not work on on_train_epoch_end
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 31.4k
- Forks
- 3.8k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 6
Description
### Bug description
I am trying to compute metrics that I have aggregated. There is an issue with torchmetrics that is already addressed here https://github.com/Lightning-AI/pytorch-lightning/issues/18803 (and not solved yet) so I am trying to aggregate my metric alone.
At each step (training and validation step) I am printing my metric as follows:
```
self.log("train_loss", loss, on_step=True, on_epoch=True, prog_bar=True, logger=True, sync_dist=True)
```
I have a tensor that I want to sync between all gpus, and I am trying to use inside `on_validation_epoch_end` and `on_train_epoch_end`:
1. Native pytorch distributed `all_gather`
2. Lightning `self.all_gather`
Both do not work, and the process is stuck, like if all the gpu are waiting for rank 0 to answer.
EDIT:
I see that if I log using `on_epoch=False`, the problem does not occur
```
self.log("train_loss", loss, on_step=True, on_epoch=False, prog_bar=True, logger=True, sync_dist=True)
```
Thanks
### What version are you seeing the problem on?
v2.5
### How to reproduce the bug
```python
```
### Error messages and logs
```
# Error messages and logs here please
```
### Environment
Current environment
```
#- PyTorch Lightning Version (e.g., 2.5.0):
#- PyTorch Version (e.g., 2.5):
#- Python version (e.g., 3.12):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
```
### More info
_No response_
cc @justusschock
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files, tests, or runnable reproduction are provided. Start by building a minimal distributed-training reproduction from the self.log and self.all_gather snippets, then inspect the training and validation epoch-end hook paths; done means gathering completes without hanging when on_epoch logging and sync_dist are enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- distributed-systems, machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100