Lightning-AI / Lightning-AI/pytorch-lightning
FSDP Strategy not working with bfloat16
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 31.4k
- Forks
- 3.8k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 6
Description
### Bug description
Flatten Param is breaking , "ValueError: Must flatten tensors with uniform dtype but got torch.bfloat16 and torch.float32". Models are loaded from huggingface in bf16 precision but fsdp couldn't autocast them to float32
### What version are you seeing the problem on?
v2.4
### How to reproduce the bug
_No response_
### Error messages and logs
ValueError: Must flatten tensors with uniform dtype but got torch.bfloat16 and torch.float32
### Environment
Current environment
```
#- PyTorch Lightning Version (e.g., 2.4.0):
#- PyTorch Version (e.g., 2.4):
#- Python version (e.g., 3.12):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
```
### More info
@awaelchli @rohitgr7
_No response_
cc @lantiga
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or reproducible example is named. Start by reproducing the FSDP Strategy failure with a Hugging Face model loaded in bfloat16, then trace the parameter-flattening and autocast path; done means the model runs without the mixed-dtype ValueError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- distributed-systems, machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100