Lightning-AI / Lightning-AI/pytorch-lightning
Pinning the `lightning` package doesn't pin the `pytorch_lightning` package
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 31.4k
- Forks
- 3.8k
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 6
Description
Bug description
For reasons, I have to use torch<2.0; I can see that in lightning 2.3.0 the torch dependency was constrained to be >2.0, so I decided to pin it, but (after much debugging) I realised that lightning was installing a different version of pytorch-lightning, which was the actual package causing the issues.
What version are you seeing the problem on?
v2.2, master
How to reproduce the bug
pip install lightning==2.2.5
This will install `pytorch-lightning==2.3.0`.
I thought the name change was mostly for branding purposes, so I suppose that it would be nicer to pin the package here?
Error messages and logs
# Error messages and logs here please
Environment
Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):
More info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported installation with pip install lightning==2.2.5 and inspect the resulting dependency metadata for pytorch-lightning. Trace where the lightning package declares its PyTorch Lightning dependency. Done means the package constraint matches the intended compatibility and the reported installation no longer selects an incompatible version.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100