Lightning-AI / Lightning-AI/pytorch-lightning

Update the docformatter pre-commit action

Open
#16,257 7 comments 0 reactions 1 assignee View on GitHub

@MrShevan is already working on this.

Since Jan 5, 2023.

ci good first issue
Dominant language
Python
Stars
31.4k
Forks
3.8k
Avg merge
6d 7h
Merged PRs (30d)
6

Description

### Outline & Motivation

docformatter v1.5.1 was released but we are still using v1.4 after we saw issues.

[github.com/PyCQA/docformatter: v1.4 → v1.5.1](https://github.com/PyCQA/docformatter/compare/v1.4...v1.5.1)

### Pitch

Update this line: https://github.com/Lightning-AI/lightning/blob/3326e65bb2f7de2040bdf300dca062c627cdddb1/.pre-commit-config.yaml#L59

To `v1.5.1`

Then resolve the failures caused by the update.

### Additional context

Already attempted in https://github.com/Lightning-AI/lightning/pull/16224 and #15344

cc @borda @carmocca @akihironitta

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.