Lightning-AI / Lightning-AI/litgpt
Support LoRA for nn.Embeddings
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13.7k
- Forks
- 1.5k
- Avg merge
- 15h 37m
- Merged PRs (30d)
- 1
Description
Hello @carmocca 👋
How do you think: should be `LoRA` for `nn.Embeddings` supported by this repo? That's basically the last weight matrix that is not supported.
And the [code](https://github.com/microsoft/LoRA/blob/main/loralib/layers.py#L32) is in the orig repo anyway.
Just want to clarify it before spending time on a PR.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the repository's existing LoRA support and the referenced loralib implementation for embedding layers. The issue does not name a source file or test, so first identify the relevant nn.Embeddings entry point and existing coverage; done means LoRA support for embeddings is implemented and verified consistently with the other supported weight matrices.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100