Lightning-AI / Lightning-AI/litgpt
Pre-Layernorm Naming
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 13.7k
- Forks
- 1.5k
- Avg merge
- 15h 37m
- Merged PRs (30d)
- 1
Description
Since we now support post-LN via #1545, it may make sense to designate the other LN's as Pre-LN for code readability/educational purposes. (And maybe also add a flag to enable/disable for research purposes)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the post-LN work in issue #1545 and locating the existing LayerNorm naming in the Python implementation. Determine which names should be designated Pre-LN and whether the optional research flag is part of the agreed scope; completion should include consistent naming and any documented, tested flag behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100