Lightning-AI / Lightning-AI/litgpt
Is it correct to keep using adapter_kv_cache during training in litgpt/adapter.py?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 13.7k
- Forks
- 1.5k
- Avg merge
- 15h 37m
- Merged PRs (30d)
- 1
Description
Is it correct to keep using `adapter_kv_cache` during training in `litgpt/adapter.py`? I think `self.adapter_wte` and `self.attn` are updated during training, so ak and av should not use `kv_cache`. Thank you very much!
But it seems that during training, `self.adapter_kv_cache` was also used.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in litgpt/adapter.py by tracing the training path around adapter_kv_cache, self.adapter_wte, and self.attn. Compare when the cache is read or updated during training, then establish the expected behavior and verify it with the relevant training checks; done means the cache handling is confirmed or corrected with evidence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100