Lightning-AI / Lightning-AI/lit-llama
`generate.py` and `generate/full.py` could be merged
Open
Nobody has claimed this yet.
good first issue
inference
- Dominant language
- Python
- Stars
- 6.1k
- Forks
- 517
- PR merge metrics
- No merged PRs in 30d
Description
Proposed in https://github.com/Lightning-AI/lit-llama/pull/255
The only difference in logic is the instruction tuning. We could add a flag for it as in https://github.com/Lightning-AI/lit-llama/pull/278
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare generate.py and generate/full.py, starting with the proposed approach in pull requests 255 and 278. Identify the instruction-tuning logic that differs and define the flag behavior before consolidating the scripts. Done means one shared generation implementation supports both modes without changing their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100