Lightning-AI / Lightning-AI/lit-llama

To mask or not to mask?

Open
#290 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6.1k
Forks
517
PR merge metrics
No merged PRs in 30d

Description

I am not understanding the conceptual usefulness of masking out the prompt.
I have seen that there is a comment in scripts/prepare_alpaca.py that says:

mask_inputs: bool = False, # as in alpaca-lora

Is it recommended when fine-tuning with lora? Is there some benefit elsewhere?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the mask_inputs option and its comment in scripts/prepare_alpaca.py. Review how prompt masking is used during LoRA fine-tuning and document when it is recommended, including the relevant trade-offs. Done means the repository clearly explains whether masking should be enabled and why.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.