Lightning-AI / Lightning-AI/lightning-thunder
support unary positive (and systematically check the __ ops?)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
This gets quite the traceback when it should just map `__pos__` to `torch.Tensor.positive`
```
import thunder, torch
def fn(a):
return +a
jfn = thunder.jit(fn)
inp = torch.randn(5)
jfn(inp)
```
Maybe it would be worthwhile to check the dunder methods (unless we already did and just missed this).
cc @apaz-cli
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the shown function with thunder.jit and a torch tensor, then trace unary-operator dispatch for Python's __pos__ operation. The change is done when the example runs by mapping __pos__ to torch.Tensor.positive and the related dunder-operation handling has been checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100