Lightning-AI / Lightning-AI/lightning-thunder

Implement TensorBase.masked_fill_

Open
#335 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement nemo
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

### 🚀 Feature

Implement [`TensorBase.masked_fill_`](https://pytorch.org/docs/stable/generated/torch.Tensor.masked_fill_.html)

### Motivation

NeMo's [MegatronClipModel](https://github.com/NVIDIA/NeMo/blob/main/examples/multimodal/vision_language_foundation/clip/megatron_clip_pretrain.py)

cc @tfogal

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating TensorBase and reading the PyTorch masked_fill_ documentation linked in the issue. Check how the operation is used by NeMo's MegatronClipModel, then verify that TensorBase supports the documented behavior needed there and add or run the relevant project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
compilers, machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.