Lightning-AI / Lightning-AI/lightning-thunder

Add the torch.compile executor as a test executor

Open
#299 1 comment 0 reactions 0 assignees View on GitHub
enhancement testing torch.compile
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

## 🚀 Feature

### Motivation

Our op coverage for the torch.compile executor could be better, currently we only add it in the partial from in https://github.com/Lightning-AI/lightning-thunder/blob/3cd157b9bec6a450115f01125ee2653227988507/thunder/tests/framework.py#L337

### Pitch

Add the `TorchCompileCatExecutor` and `TorchCompileExecutor` test executors to https://github.com/Lightning-AI/lightning-thunder/blob/3cd157b9bec6a450115f01125ee2653227988507/thunder/tests/framework.py#L242 and work through the errors that pop up in CI

### Additional context

Requires #140 to land first.

cc @apaz-cli

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in thunder/tests/framework.py around lines 242 and 337, comparing the existing partial torch.compile executor setup with the requested TorchCompileCatExecutor and TorchCompileExecutor entries. Confirm that issue #140 has landed first, then run the relevant test suite or CI checks and investigate the errors that appear. Done means both executors are included as test executors and CI passes for the affected coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
ci-cd, compilers, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.