Lightning-AI / Lightning-AI/lightning-thunder
Remove `xfail`s once PyTorch autograd stabilizes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/Lightning-AI/lightning-thunder/issues/2803 shows how changes in PyTorch autograd internals are causing errors in Thunder. Currently, there's a temporary patch to progress the CI: https://github.com/Lightning-AI/lightning-thunder/pull/2805.
These xfails must be removed once the autograd issues are resolved.
cc @mruberry
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read issue #2803 and pull request #2805 to understand the PyTorch autograd errors and temporary CI patch. Locate the affected xfails from the patch or CI results, then remove them only after the autograd issues are resolved. Run the relevant CI tests and confirm they pass without those xfails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100