Lightning-AI / Lightning-AI/lightning-thunder

`args_tensor_mask` has been removed from `torch.ops.higher_order.autograd_function_apply`

Open
#2,803 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

autograd
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

A recent Pytorch PR changed the autograd_function_apply function API by dropping the usage of args_tensor_mask keyword argument.

Currently, thunder reads this key in the kwarg dict leading to a KeyError.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in thunder/core/jit_ext.py at the linked line and inspect how autograd_function_apply kwargs are read. Compare that access with the current PyTorch API described in the issue, then verify that the removed args_tensor_mask key no longer causes a KeyError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.