Lightning-AI / Lightning-AI/lightning-thunder

Add _grouped_mm grad rule

Open
#2,362 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

autograd
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

As a follow up to #2326 , we should add grad rule for `prims._grouped_mm`.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked follow-up context in issue #2326 and locate the implementation of `prims._grouped_mm`. Determine how gradient rules are defined for comparable primitives, then add the corresponding rule and verify that grouped matrix multiplication gradients work as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
compilers, machine-learning
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.