Lightning-AI / Lightning-AI/lightning-thunder

Conditional executor registration

Open
#2,278 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code health executors
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

🐛 Bug

Opening this issue to have a chat about executors that rely on external libraries. Should an executor register itself if the external library is not available?

In apex the current situation is that the executor registers itself but then it conditionally register the implementation based on weather the apex library is available or not. In the case of nvfuser instead, the executor registers itself only if nvfuser is available.

What should be the desired behavior?

ps. this issue came about from looking at this #2226

cc @borda @mruberry

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the executor registration behavior described for apex and nvfuser, using issue #2226 for context. First determine whether registration should depend on the external library being available; done means the project has an agreed, consistent behavior for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.