Lightning-AI / Lightning-AI/lightning-thunder
Tracker for [Fix runtime-trace shape/dtype/device mismatch]
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
This issue tracks the OpInfo instances with outstanding [Fix runtime-trace shape/dtype/device mismatch] TODOs in [thunder/tests/opinfos.py](thunder/tests/opinfos.py).
Related: #2069
Outstanding OpInfos:
- [x] `copysign` -- prims.where <- #2135
- https://github.com/Lightning-AI/lightning-thunder/blob/8444f90c594c3f29f9d07691cee7f3245a6dd16e/thunder/tests/opinfos.py#L2300-L2312
- [x] `floor_divide` -- prims.where <- #2135
- https://github.com/Lightning-AI/lightning-thunder/blob/8444f90c594c3f29f9d07691cee7f3245a6dd16e/thunder/tests/opinfos.py#L2347-L2388
- [ ] `diagonal` -- clang advanced indexing?
- https://github.com/Lightning-AI/lightning-thunder/blob/8444f90c594c3f29f9d07691cee7f3245a6dd16e/thunder/tests/opinfos.py#L3730-L3741
- [ ] `unfold` -- clang advanced indexing?
- https://github.com/Lightning-AI/lightning-thunder/blob/8444f90c594c3f29f9d07691cee7f3245a6dd16e/thunder/tests/opinfos.py#L3938-L3947
- [ ] `__getitem__` -- clang advanced indexing?
- https://github.com/Lightning-AI/lightning-thunder/blob/8444f90c594c3f29f9d07691cee7f3245a6dd16e/thunder/tests/opinfos.py#L4210-L4237
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in thunder/tests/opinfos.py at the linked ranges for diagonal, unfold, and __getitem__, then review related issues #2069 and #2135 for context. Compare the remaining OpInfo TODOs against runtime-trace shape, dtype, and device behavior. Done means resolving the three unchecked entries and updating the tracker.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100