Lightning-AI / Lightning-AI/lightning-thunder

[pre-commit] Bump Python default version to 3.12?

Open
#2,152 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ci
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Lightning-AI/lightning-thunder/blob/4741b440d0e9e187b765e7dd9b0a23b3c2b6d7bc/.pre-commit-config.yaml#L1-L2

According to https://github.com/Lightning-AI/lightning-thunder/blob/4741b440d0e9e187b765e7dd9b0a23b3c2b6d7bc/dockers/ubuntu-cuda/Dockerfile#L15, I think the python version used in CI is 3.12, so I think it's worth thinking of the bump.

What do you think?

cc @borda

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the Python version in .pre-commit-config.yaml at the referenced lines with the version used in dockers/ubuntu-cuda/Dockerfile. Check the pre-commit configuration and relevant CI runs first. Done means the default versions are intentionally aligned and the pre-commit checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.