Lightning-AI / Lightning-AI/lightning-thunder
Investigate problems in with apex executor surfaced in thunder/tests/test_networks.py::test_hf_for_nemo and potentially reenable apex by default
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
When using the apex executor, `thunder/tests/test_networks.py::test_hf_for_nemo` started to fail with Transformers 4.50.2, see #1920 .
(Enabling can be tested eg by passing `executors=('apex', *thunder.get_default_executors())` in the thunderfx call)
As suggested by @IvanYashchuk in the discussion of the original #2061 , I dropped apex as a default executor in that PR pending investigation.
cc @crcrpar
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with thunder/tests/test_networks.py::test_hf_for_nemo and the failure context in #1920 and #2061; reproduce the failure with Transformers 4.50.2 and an explicit apex executor in the thunderfx call. Determine the cause and verify that the test passes, then establish whether apex can safely be reenabled as a default executor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100