Lightning-AI / Lightning-AI/lightning-thunder

In place operations on intermediate tensors

Open
#1,893 0 comments 0 reactions 2 assignees View on GitHub

@beverlylytle is already working on this.

Since Mar 26, 2025.

in-place
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

Investigate an approach to in-place operation support to enable [this test](https://github.com/Lightning-AI/lightning-thunder/blob/71f89ab49288fcd54f65bd4633aac72dd72560ad/thunder/tests/test_update_aliases.py#L250) for nvfuser. The test passes with either `skip_inplace_alias_updates` or `skip_inplace_functionalization ` set to `True`. However, with the former, it comes at the cost of introducing fusion breaks. This investigation might consist of two parts. 1. Understand what can be done to support in-place ops in NvFuser, and 2. understand how to gracefully blend update_aliases and functionalization.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.