Lightning-AI / Lightning-AI/lightning-thunder

Feed fp16/bf16 friendly values to test cases

Open
#1,803 0 comments 0 reactions 1 assignee View on GitHub

@riccardofelluga is already working on this.

Since Feb 26, 2025.

enhancement testing
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

## 🚀 Feature

When testing for numerical correctness it would be a good feature to have the SampleInput to recognize if the given value from the practitioner are directly representable in half precision formats, and if not it should clip them to the closest value that satisfy the criteria.

This idea came up from the issue with half precision testing while feeding full precision scalar inputs that cannot be represented directly in fp16/bf16 #1791 and #703

cc @mruberry

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.