Lightning-AI / Lightning-AI/lightning-thunder
Transforming traces should always precede a domination check
@ali-alshaar7 is already working on this.
Since Jan 22, 2025.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
## 🚀 Feature
### Motivation
An improperly applied trace transformation can sometimes lead to domination errors in the data-flow graph. These often result in `KeyError: 't*` errors several blocks down the road. It would be helpful if more useful errors could be emitted earlier on.
### Pitch
A transform that creates domination errors e.g` (A = Node(C, B); C = Node(X) # where C's definition proceeds its use)` will have a check that's applied after every transform is applied indicate the error and its location in the trace.
cc: @t-vi
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.