Lightning-AI / Lightning-AI/lightning-thunder

backward creates inconsistent proxies between args and unpacking them

Open
#1,633 0 comments 0 reactions 1 assignee View on GitHub

@t-vi is already working on this.

Since Jan 10, 2025.

autograd tracing architecture
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

In generating the backward (in hit in benchmark_litgpt llama 2 7b without checkpointing), the collection of saved tensors in the args contains different proxies than the one in the collection proxy used in the unpacking symbol.
This should be consistent.

cc @t-vi @mruberry @lantiga

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.