Lightning-AI / Lightning-AI/lightning-thunder
Improve the logic of fsdp bucket naming function
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
unrelated to the PR but good example, @t-vi @lantiga shall we create issues for all these todos in code, so it won't be lost, I bet (at least me) would not come back to one todos in code :)
Originally posted by @Borda in https://github.com/Lightning-AI/lightning-thunder/pull/103#discussion_r1545197835
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading thunder/distributed/init.py around line 292 and inspect the bucket naming function and its surrounding TODO context. The issue does not define the intended naming logic or a completion test, so the expected behavior must be clarified before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100