Lightning-AI / Lightning-AI/lightning-thunder
Re-enable inductor tests on windows
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
We had to disable a couple tests on windows because they now fail on windows:
```
FAILED thunder/tests/test_torch_compile_executor.py::test_torch_compile_litgpt - torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
RuntimeError: Compiler: cl is not found.
FAILED thunder/tests/test_autocast.py::test_torch_compile_autocast -
torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
RuntimeError: Compiler: cl is not found.
```
## 🐛 Bug
Re-enable the tests.
### To Reproduce
Just drop the `or platform.system() == Windows` in the existing `skipIf` clause on these two tests.
### Additional context
Example CI run where this failed: https://github.com/Lightning-AI/lightning-thunder/actions/runs/11390861866/job/31693384602?pr=1324
cc @borda
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in thunder/tests/test_torch_compile_executor.py and thunder/tests/test_autocast.py, locating the existing skipIf clauses for Windows. Run test_torch_compile_litg and test_torch_compile_autocast on Windows with the required compiler available; done means both tests execute and pass without the Windows skip.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- operating-systems, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100