Lightning-AI / Lightning-AI/lightning-thunder
Skipped distributed tests show up as passed (return 0)
Open
Nobody has claimed this yet.
ci / tests
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
Note that this can be very misleading because a skipped test also returns 0, so it can make it seem like a test passed when it didn't run
Originally posted by @carmocca in https://github.com/Lightning-AI/lightning-thunder/pull/130#discussion_r1551712686
cc @borda
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with scripts/run_standalone_tests.sh at lines 41-48 and inspect how skipped distributed tests determine their exit status. Run the standalone test script with a skipped test and verify that its result is distinguishable from a passing test rather than returning 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100