Lightning-AI / Lightning-AI/lightning-thunder
Reduce siginfo in traces to optional
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
There currently is a lot of overlap with args and it's a bit annoying to have to care about siginfo whenever constructing an intermediate trace. So maybe it would be good to use siginfo only for the gaps to trace.args and trace.kwargs to not need to append siginfo for intermediate traces we produce.
cc @carmocca @borda
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the intermediate trace construction and the uses of trace.args, trace.kwargs, and siginfo. Trace how siginfo is currently required and identify the gaps that are not already represented by args or kwargs. Done means intermediate traces can omit siginfo when it adds no information, while retaining the necessary gaps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100