Lightning-AI / Lightning-AI/lightning-thunder
provide trace checker and debug mode with it enabled
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
We are currently plagued a bit with inconsistency issues in traces and might have good use for a checker and then having a mode where we do this a lot:
- sometimes the shape metadata is not update properly (see #1179 )
- the return has inputs and outputs that should match (though we might possibly drop the outputs), but we have places that update only one (and other places that use the other), encountered in #1164,
- we currently do not guard against having two proxies with the same name. Proxy creation does compare to used names, but at various places, we copy proxies between traces (notably between prologue and compute/epilogue and forward/backward). This leads to all sorts of funny issues (encountered a lot in #1164 with forward/backward), but potentially also in other hard to debug issues, (given the brittleness we have with this, we might also make traces "own" proxies rather than them being "freely floating").
cc @carmocca @borda
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.