Lightning-AI / Lightning-AI/lightning-thunder

don't silently drop symbols without implementation

Open
#1,169 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tracing architecture
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

Currently, if a symbol does not have an implementation, it is silently dropped in transform_for_execution.

This was one factor of making it hard to debug #1166 and is quite a UX hazard when things go wrong for whatever reason.

cc @apaz-cli

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the transform_for_execution entry point mentioned in the issue and inspect how symbols without implementations are handled. Trace the path for the case described in #1166, then identify the relevant tests or test commands. Done means missing implementations are no longer silently dropped and the resulting behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.