Lightning-AI / Lightning-AI/lightning-thunder

remove jit(fsdp(model)) codepath

Open
#1,129 6 comments 1 reaction 1 assignee View on GitHub

@t-vi is already working on this.

Since Sep 9, 2024.

Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

The old codepath is not composable with other transforms, does not offer gathering of state dicts as easily etc.

Removing, of course depends on NVIDIA benchmarking not needing it. I think we (@crcrpar actually) switched a couple of months ago or so.

@mpatel31415 @tfogal @crcrpar @IvanYashchuk wdyt?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.