Lightning-AI / Lightning-AI/lightning-thunder

`_include_te_fp8_autocast` as CompileOption instead of an attribute to Trace

Open
#1,050 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement thunderfx TransformerEngine
Dominant language
Python
Stars
1.5k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

Makes me wonder whether this could / should be a compile data information ("option") rather than on the trace?

_Originally posted by @t-vi in https://github.com/Lightning-AI/lightning-thunder/pull/1021#discussion_r1729157160_

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns `_include_te_fp8_autocast`, `CompileOption`, and `Trace`; start by locating their definitions and the code that reads this setting. Trace how the value is propagated, then determine whether the proposed ownership change is compatible with existing compile behavior. The issue does not name files, tests, or a concrete acceptance criterion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.