LibreSign / LibreSign/libresign

Remove dependency from Imagick extension

Open
#5,567 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
PHP
Stars
818
Forks
146
Avg merge
11h 31m
Merged PRs (30d)
326

Description

Is your feature request related to a problem? Please describe.

nextcloud-snap does not support imagick hence we get filed with logs

no app in context
Exception
Class "Imagick" not found in file '/var/snap/nextcloud/50464/nextcloud/extra-apps/libresign/lib/Service/SignatureBackgroundService.php' line 68
Describe the solution you'd like

Ignore signature logo/images if imagick is not available

Maybe we can use jmagick like done with the other j* for pdf management

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with extra-apps/libresign/lib/Service/SignatureBackgroundService.php at line 68 and inspect how Imagick is used when preparing signature backgrounds. Confirm the behavior when the extension is unavailable, then ensure signature logos and images are safely ignored without breaking signing; add or update the relevant tests if the repository identifies them.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.