Libera-Chat / Libera-Chat/sable

Inconsistent behavior when `history_receiver.recv()` returns `None`

Open
#141 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
132
Forks
14
PR merge metrics
No merged PRs in 30d

Description

ServicesServer ignores it:

https://github.com/Libera-Chat/sable/blob/3c6bc2ffbcc680e3bbdcf08cd5bba34adf08f0a9/sable_services/src/server/mod.rs#L109-L121

but HistoryServer breaks the loop:

https://github.com/Libera-Chat/sable/blob/3c6bc2ffbcc680e3bbdcf08cd5bba34adf08f0a9/sable_history/src/server/mod.rs#L68-L75

HistoryServer is probably the correct one here, it looks like ServicesServer would enter an infinite loop when the associated sender is dropped

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the None handling in sable_services/src/server/mod.rs around lines 109-121 with sable_history/src/server/mod.rs around lines 68-75. Verify which behavior is correct when the associated sender is dropped, then make the two servers consistent and confirm ServicesServer cannot enter an infinite loop.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.