Lemoncode / Lemoncode/quickmock

Keyboard blocked even for dev tools

Open
#394 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
70
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Maybe we are using a preventDefault when trapping the keyboard events?

Right now we got this

src/pods/canvas/use-keyboard-displacement.tsx

  useEffect(() => {
    const handleKeyDown = (event: KeyboardEvent) => {
      if (isInlineEditing) {
        return;
      }

      event.preventDefault();

      if (selectionInfo.selectedShapesIds.length === 0) {
        return;
      }

Since is keyboard displacement, we should only apply the prevent default on the keyboard command

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/pods/canvas/use-keyboard-displacement.tsx, especially the handleKeyDown logic around event.preventDefault(). Trace which keyboard input is the displacement command and ensure unrelated keyboard shortcuts, including developer-tool shortcuts, are not blocked. Done means displacement still works while those other shortcuts remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.