LeaVerou / LeaVerou/HTML5-Progress-polyfill
IE <= 9 failure
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 178
- Forks
- 85
- PR merge metrics
- No merged PRs in 30d
Description
I have a page using KnockoutJS. This polyfill breaks because of the implementation of isInited(). I'm assuming KO is cloning the element somehow that's not compatible with your polyfill.
The current implementation looks like this:
isInited: function(progress) {
return progress.getAttribute('role') === 'progressbar';
}
I changed it to look like this and it fixed it:
isInited: function(progress) {
return 'position' in progress;
}
I'd submit a pull request but I'm not certain this is the best solution.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the polyfill for the isInited(progress) implementation and reproduce the failure using the linked JSFiddle with IE 9 and KnockoutJS. Compare the role-based check with the proposed position check, then verify that the page no longer fails in the affected browser scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100