LabyMod / LabyMod/labymod4-server-api

can't disable the Mini Map Addon

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
12
Forks
3
PR merge metrics
No merged PRs in 30d

Description

General Troubleshooting
  • I am using the latest version of the LabyMod 4 Server API.
  • I am using the latest version of LabyMod.
  • I have checked for similar issues on the Issue-tracker.
  • I have checked for Pull Requests that might already address this issue.
Platforms

Spigot / Bukkit, Other (please specify in the additional information text field at the bottom)

Affected Minecraft Version(s)

ALL of the Labymod Versions

Expected Behaviour

I can disable other addon with below code, but when im going to disable "labysminimap" it doesnt function at all.

Code Example for Reproduction Steps
@Override
    public void onEnable() {
        instance = this;
        LabyModProtocolService.initialize(this);
        getServer().getPluginManager().registerEvents(new Listener() {
            @EventHandler
            public void onLabyModPlayerJoin(LabyModPlayerJoinEvent event) {
                Player player = event.labyModPlayer().getPlayer();
                List<String> addonsToDisable = new ArrayList<>();

                addonsToDisable.add("keystrokes"); // it works, getting disabled.
                addonsToDisable.add("labysminimap"); // it doesnt function

                LabyModPlayer labyModPlayer = LabyModProtocolService.get().getPlayer(player.getUniqueId());

                labyModPlayer.disableAddons(addonsToDisable);
                requestAddons(player);
                player.sendMessage(ChatColor.RED + "LabyMod Integration has been enabled, due to the server rules Minimap addon has been disabled on this gamemode.");
            }
        }, this);
    }
Exception or Error
N/A
Additional Information

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the LabyModPlayer.disableAddons(addonsToDisable) entry point shown in the reproduction and compare the handling of "keystrokes" with "labysminimap". Reproduce the join-event example, then verify that the Mini Map addon is disabled in the same way as the working addon.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.