LabyMod / LabyMod/discord-webhook-bundle

Reset Object state after sending invoking webhook (bug?)

Open
#1 0 comments 0 reactions 1 assignee View on GitHub

@scrummer is already working on this.

Since Jan 25, 2022.

bug enhancement
Dominant language
PHP
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Current state

As the various clients are being saved as service within the symfony container it becomes absolutely necessary that the services are being reset after the webhook was invoked.
If not, it can cause issues like contents being sent several times when invoking the same client with other content from an other part of the code.

Desired solution

After DiscordWebook::send() was invoked, all the properties (exclusive the ones configured via Symfony configuration) must be reset to the initial state (e.g. clear message, file(s) and remove all embeds from embeds-collection).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.