LMMS / LMMS/lmms

Add "pseudo-pedal" note type

Open
#8,462 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Enhancement Summary

I'd like to have a specific type of note in LMMS that plays for as long as possible, like notes on a piano when pressing the pedal. More specifically, this note should not emit a "note release" event, unless another note of the same MIDI value is pressed, or playback is stopped.

The closest type of note to match this at the moment are the "red notes" that are created when inserting into a MIDI clip in the Pattern Editor. They do not last indefinitely, however. I think they stop after one measure?
Image

Implementation Details / Mockup

Not quite sure how to implement this yet.

Please search the issue tracker for existing feature requests before submitting your own.
  • I have searched all existing issues and confirmed that this is not a duplicate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Pattern Editor and trace how the existing red notes produce MIDI note events. Define how a pseudo-pedal note should behave for repeated MIDI values and stopped playback, then verify that it avoids note-release events except in those cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.