LMMS / LMMS/lmms

Allow replace the patch in Patman with a drag/drop

Open
#8,065 2 comments 0 reactions 0 assignees View on GitHub
enhancement gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

https://github.com/LMMS/lmms/blob/2eea79bdd349a0b385c9a371e0dc6c8dccfc5b6d/plugins/Patman/Patman.cpp#L601

And,
https://github.com/LMMS/lmms/blob/2eea79bdd349a0b385c9a371e0dc6c8dccfc5b6d/plugins/Patman/Patman.cpp#L579

Two places use "samplefile" word, while the dropped in file comes with: "patchfile" request.
This is prohibiting replacement of the sample when .pat file is dropped in.

Linking: #7849 too.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open plugins/Patman/Patman.cpp at the references around lines 579 and 601, then compare how the drag/drop request names the incoming file with the two uses of "samplefile". The change is complete when dropping a .pat file allows the existing sample to be replaced; review linked issue #7849 for related context.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.