LMMS / LMMS/lmms

Replace remaining "legacy" knobs with enhanced ones

Open
#7,911 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Pull request https://github.com/LMMS/lmms/pull/7525 has introduced the option to individually set the font sizes for knob labels by making them adhere to the font size that's set in the widgets font. It also allows to set the font sizes of individual knobs via CSS.

Due to layout constraints it was not possible to introduce this new feature in all places and some knobs still have to fall back to legacy rendering of the labels. Attempting to fix all these places would have been too much scope and too much work for the aforementioned PR. Hence it should be attempted to fix these remaining places one after the other.

The following gives an overview with images of the remaining places. You will find that most of the problems are caused by missing layouts, hard-coded positions and insufficient space provided by the encompassing parent widget.

## Delay plugin
![Image](https://github.com/user-attachments/assets/d8e34395-1cd4-4042-9924-252897e02676)

This plugin might need some rework in general as the knobs do not align.

## EffectView
![Image](https://github.com/user-attachments/assets/c1a64282-8bf4-4af0-b975-99c9a008547b)

## EnvelopeAndLfoView
![Image](https://github.com/user-attachments/assets/da98821d-e01f-47a8-af36-34c3fbf2440a)

This view looks very crowded and should get more space to present its widgets.

## InstrumentFunctionViews
![Image](https://github.com/user-attachments/assets/1d820467-c458-43d7-88ad-b25a54f48979)

## InstrumentSoundShapingView
![Image](https://github.com/user-attachments/assets/2929adf9-9002-4415-bfc1-0ee1e80fb101)

## InstrumentTrackView
![Image](https://github.com/user-attachments/assets/280e232a-cd96-4cec-8a49-edd65ce947ac)

This view might benefit from a bit more vertical space.

## SampleTrackView
![Image](https://github.com/user-attachments/assets/bb02b5a7-6f4f-4ae5-ac53-9f67eefebf70)

This view might benefit from a bit more vertical space.

# Other places
The Carla plugin also uses the legacy knobs. I do not have Carla installed and therefore cannot provide a screenshot. This is likely also the reason why it was not adjusted in the PR in the first place. It might even be a low-hanging fruit for any developer who has Carla installed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Delay plugin, EffectView, EnvelopeAndLfoView, InstrumentFunctionViews, InstrumentSoundShapingView, InstrumentTrackView, SampleTrackView, and Carla plugin UI implementations. Compare their layouts and knob rendering with the enhanced implementation introduced by pull request #7525. Done means the remaining legacy knobs use the enhanced rendering without breaking the views' layout; verify each affected view visually.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design, desktop
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.