Crosshair/mouse position indicator shows when mouse not in editor window
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### System Information
Windows 11
### LMMS Version(s)
Version 1.3.0-alpha.1.737+g6b494bd7a (win32/x86_64, Qt 5.15.6, GCC 9.3-posix 20200320).
### Most Recent Working Version
_No response_
### Bug Summary
When a specific window is focused and the mouse pointer is in it, a positional indicator shows up (crosshair for automation editor, highlighted note indicator for piano roll, etc).
By crosshair I mean the giant perpendicular lines that intersect at the mouse position.
When the mouse pointer is moved outside of the window while it's still in focus, the indicator still shows up.
**This _may_ be the cause of weird issues like being able to "draw" in the automation window while the track is playing if the playing position indicator moves through the position of the automation track. A similar issue occurs in piano roll windows.** See the final screenshot.
This looks similar to #1052, but perhaps the condition of losing focus isn't enough.
### Expected Behaviour
Show crosshair in (focused) windows only if mouse pointer is actually in the drawing region of those windows (ie, hovering above the drawing region specifically).
### Steps To Reproduce
1. Open automation editor in LMMS so it is focused.
2. Hover mouse pointer over automation editor so crosshair is showing.
3. Move mouse pointer outside of automation editor.
4. See the line that still remains in automation editor.
**This occurs with piano roll windows too.**
### Logs
_No response_
### Screenshots / Minimum Reproducible Project
### Please search the issue tracker for existing bug reports before submitting your own.
- [x] I have searched all existing issues and confirmed that this is not a duplicate.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior first in the automation editor and piano roll, following the issue's four-step sequence and checking both drawing regions. Trace how each editor handles the mouse leaving its drawing area; done means the crosshair or note indicator disappears outside that region while still appearing when the pointer is over it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100