Disable processing for muted instruments
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
as i understand in track.cpp 2051 toggleSolo is just muting all others, but i think that solo should disable processing of others, not just muting, because with high load there's no way to omit CPU overlapping.
so if only few instruments are in solo mode only their automation, fx and synth can work.
maybe to do fx work more clear, it's better to set fx.channel for each instrument with fx.enabled, so whole fx rack of instrument could be also disabled.
for muting i'd suggest a muteAllBtn and just unmute needed instruments
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at track.cpp around line 2051 and trace how toggleSolo currently mutes other instruments. Determine where automation, effects, and synth processing are scheduled, and clarify how solo mode should disable that work while preserving the requested mute behavior. Done should mean that only soloed instruments process their automation, effects, and synths, with the behavior verified in the relevant existing tests or processing path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, performance
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100