LMMS / LMMS/lmms

Update LFO Controller status on playback position change while playing

Open
#7,528 0 comments 0 reactions 0 assignees View on GitHub
enhancement gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Enhancement Summary

Submitting in good faith, because I have not seen a similar Issue in the tracker.

Currently, on playback start, the position is accounted for for LFO controllers in determining their beginning state.
This allows consistent playback of sections.

An issue arises when you have position changes while it plays, triggered by:
-Moving the playback cursor with your mouse.
-A loop point being reached.
These events do not trigger a reevaluation of the starting status of the LFO controller, resulting in differing playback.

### Implementation Details / Mockup

I propose the following change:
-Update the LFO Controller status on playback position change while playing.
This should not have any breaking issues.

Updating the status on loop points may be a breaking change for some projects that rely on looping multiple times.

### Please search the issue tracker for existing feature requests before submitting your own.

- [X] I have searched all existing issues and confirmed that this is not a duplicate.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how LFO controller state is initialized on playback start and how playback cursor movement and loop-point events are handled while playing. Done means the controller status is reevaluated after both kinds of playback-position changes, with no change to behavior when playback is stopped.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.