LMMS / LMMS/lmms

Updates to SF2 Players File and Patch fields

Open
#7,482 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Enhancement Summary

Updating the SF2 Players File & Patch labels, fields & buttons.

### Implementation Details / Mockup

Was wondering if anyone would be interested in making any of the following updates to the SF2 Player.

1.) Personally I feel these fields are too small (both height and width wise) and also feel that some functions can be combined. There are many different ways that this can be done, developer/other users would have to decide. Here are some options below, in all of them, if possible maybe can increase the heights of the fields and maybe slightly increase the font size if looks okay.

OPTION A
(This one most will not agree with but)
Remove the file & patch labels as well as the icons and show only the two fields.
The fields would also act as the buttons when you click on them which would load a soundfont and open the patch window. This would be similar to how the AFP does not show filename just a full length field. It is the having two fields in this plugin that could be an issue, but once you have used the plugin for a couple minutes you know what they are for.

OPTION B
Show the FILE & PATCH labels and use fields as buttons, no icons

OPTION C
Make the FILE & PATCH labels the actual buttons but putting rectangles around them (similar to effects buttons), make both buttons the same width.
Fields would not act as buttons, also again no icons.

--------------------------------------------------------------------
2.) Not needed but could also allow for mouse scroll wheel when used on the PATCH field to scroll up / down through patches like how this occurs when done on the PATCH number indicator.
Definitely will not be added but could maybe make a mouse scroll on the FILE field scroll up / down loading the next / previous soundfonts in the current loaded soundfonts folder.
As mentioned though the fields have a narrow height so if this was added could be dangerous if both fields did this because could accidentally change the soundfont when trying to change the patch.

--------------------------------------------------------------------
3.) As mentioned FILE field is already way too narrow.
Currently it tries to show the entire path the soundfont is located in.
Just change this to show only the "/filename"
User can see the path/filename if they click on the button to open file picker.
The name is truncated most of the time anyways.

-----------------------------------------------------------------
When it comes to Linux/LMMS there is not much for instrument players, just trying to enhance what is available. Here are some other posts I made about the SF2 Player if anyone is interested.
#7480 #7481 #7496
Hopefully others will agree with some of these requests.
Thank You

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading related issues #7480, #7481, and #7496, then locate the SF2 Player UI implementation in the C++ code. Agree on one of Options A–C before changing labels, fields, or buttons; completion would require an agreed design and checks for the selected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.