Peak Controller Attack/Decay isn't a smooth curve
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### System Information
EndeavourOS
### LMMS Version(s)
12632e6b
### Most Recent Working Version
_No response_
### Bug Summary
This is the issue encountered in #1281 and #2534, I'm avoiding necroing them. As Unfa stated, the Atk/Dcy knobs seem to act more like buttons. Turning them both to 100% removes the clicking, at the cost of damping the audio being controlled. It's more noticable when the audio being used to control the controller is chaotic.
A reproducible project is attached.
### Expected Behaviour
The knobs should have an effect at all values.
### Steps To Reproduce
1. Load in two audio tracks; one to control the peak controller, and one to be controlled
2. put the peak controller on the furst track
3. bind the peak controller to the second tracks volume
### Logs
_No response_
### Screenshots / Minimum Reproducible Project
[broken-peak-controller.zip](https://github.com/user-attachments/files/16257367/broken-peak-controller.zip)
### Please search the issue tracker for existing bug reports before submitting your own.
- [X] I have searched all existing issues and confirmed that this is not a duplicate.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by opening the attached broken-peak-controller.zip project and reproducing the Peak Controller behavior using the listed two-track setup. Investigate the Peak Controller entry point and verify that the Atk/Dcy knobs have an effect across their full range without introducing clicking or unwanted damping.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100