Effect plugin controls overlap plugin UI
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### System Information
Windows 10
### LMMS Version(s)
lmms-1.3.0-alpha.1 and master
### Most Recent Working Version
_No response_
### Bug Summary
Effect controls overlap plugin ui (see screenshot)
### Expected Behaviour
Here I moved lines 230-232 below line 246 in [VstEffectControlDialog.cpp](https://github.com/LMMS/lmms/blob/master/plugins/VstEffect/VstEffectControlDialog.cpp#L230) to make it more usable, but idk if it's correct solution:
### Steps To Reproduce
Add Serum-FX VST effect, click Controls
### Logs
_No response_
### Screenshots / Minimum Reproducible Project
_No response_
### Please search the issue tracker for existing bug reports before submitting your own.
- [X] I have searched all existing issues and confirmed that this is not a duplicate.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in plugins/VstEffect/VstEffectControlDialog.cpp, especially around lines 230-246, and reproduce the issue by adding a Serum-FX VST effect and clicking Controls. Compare the current layout with the suggested line movement. Done means the effect controls no longer overlap the plugin UI on Windows 10.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc, desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100