Audible click when switching effect on/off or effect parameters via automation track
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### Bug Summary
Short noise/click is generated during automation track assisted switching of
* effect on/off ( C* Cabinet I-IV tested )
* C* Cabinet I-IV model type
* C* AmpVTS model type
* Dual filter's filter type (Hi-pass, Low-pass, ... )
* ZynAddSubFX distorsion's distorsion type
Click friendly instruments
* ZynAddSubFX
* SID
* Organic
Clicks are visible on "Spectrum Analyzer" and hearable on play or rendered track.
Looks like "knob" type controls are not affected ( volume, pan, freq, ... )
#### Steps to reproduce
example https://disk.yandex.com/d/Z2smVIGIoM9GpA
#### Expected behavior
no click
#### Actual behavior
click
#### Screenshot
#### Affected LMMS versions
current master
LMMS 1.3.0-alpha.1.517+gc2052151a
(Linux x86_64, Qt 5.15.12, GCC 13.2.0)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the attached example with automation-track switching and compare playback or rendering with the Spectrum Analyzer. Trace the handling of effect on/off and model or filter-type changes, then verify that these switches no longer produce an audible or visible click while knob controls remain unaffected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100