MIDI pitch bend import issue
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### Bug Summary
When importing MIDI files to LMMS, the pitch values are half of what they should be
#### Steps to reproduce
1. Import a MIDI file with pitch bend (e.g. flourish.mid found at "C:\Windows\Media\flourish.mid" on Windows devices)
2. Listen to it
3. Open it with VLC with the same sound font
4. Observe the difference
#### Expected behavior
The pitch values should be 2 times the values they are currently (as of 1.3.0-alpha.1)
#### Actual behavior
The pitch values are half of what they should be
#### MIDI and soundfont
[flourish pack.zip](https://github.com/LMMS/lmms/files/13382622/flourish.pack.zip)
[Output from VLC](https://cdn.discordapp.com/attachments/745802234071220344/1174797380932087989/flourish_VLC.mp3)
[Output from LMMS](https://cdn.discordapp.com/attachments/745802234071220344/1174797381288599602/flourish_LMMS.wav)
#### Affected LMMS versions
Version 1.3.0-alpha.1.102+g89fc6c960 (win32/x86_64, Qt 5.9.8, GCC 7.3-win32 20180312).
Version 1.2.2
#### ~~Logs~~
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by importing flourish.mid from the provided flourish pack, listening in LMMS, and comparing the result with VLC using the same sound font. Trace the MIDI import handling for pitch-bend values, then verify that the imported pitch values match the expected two-times scaling and the VLC output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100