LMMS / LMMS/lmms

Refactor DataFile Upgrade Routines

Open
#6,861 3 comments 0 reactions 1 assignee View on GitHub

@consolegrl is already working on this.

Since Sep 11, 2023.

  • #6866 by @consolegrl — closed without merging
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

This issue was spawned by discoveries of deficiencies in the code quality of DataFile upgrade routines found while working on PR #6850 and PR #6851 .

It's been proposed by @sakertooth to create generic routines for renaming elements and renaming attributes. I also proposed a generic lambda callback function to run on each element of a certain tag for more complex upgrade routines.

This issue is created as a deferral for me (and anyone who wants to chip in) to work on when I get time and to keep scope creep down in the two PR's mentioned.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.